Commit Graph

36 Commits

Author SHA1 Message Date
Stefan Schantl
15d9c996f9 extrahd.cgi: Add support for LVM and MDADM devices
This commit adds support for using LVM and mdadm based RAID devices
for the CGI page.

In case one or more drives/partitions are used by such a "grouped"
volume they still will displayed on the page, but can not be
configured/used. Instead the "master" volume of which the
drive/partition is part of is shown in the "mountpoint" input box.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-10-01 08:16:17 +00:00
Stefan Schantl
66cb52cb0d extrahd.cgi: Fix broken UUID check
This check was totaly broken and resulted into not beeing able to
configure/mount more than one extra harddrive.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-09-13 09:28:25 +00:00
Stefan Schantl
569c9ac668 extrahd.cgi: Adjust copyright header
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:58 +00:00
Stefan Schantl
19a3b883de extrahd.cgi: Do not allow "/mnt" or "/media" as mount points
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:57 +00:00
Stefan Schantl
65dc35dcf4 extrahd.cgi: Requires "auto" as hidden FS type to mount a new device
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:57 +00:00
Stefan Schantl
480c5253d0 extrahd.cgi: Drop select for FS selection.
This feature does not have any benefit because the linux kernel
knows best which filesystem a device/partition has.

So there is no need for a user to specify this by-hand. This also
prevents from choosing a wrong fs type and as a direct result in a
not mountable device.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:57 +00:00
Stefan Schantl
72dfa1b097 extrahd.cgi: Add missing translation strings
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:57 +00:00
Stefan Schantl
7907c1e068 extrahd.cgi: Re-order sanity check logic
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:57 +00:00
Stefan Schantl
fd815c36ea extrahd.cgi: Display mount status next to the corresponding drive
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:57 +00:00
Stefan Schantl
0aa77c2fd5 extrahd.cgi: Add is_configured function.
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:57 +00:00
Stefan Schantl
d0a6f9bdb2 extrahd.cgi: Store configured drives in a hash
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:57 +00:00
Stefan Schantl
94aeac8a05 extrahd.cgi: Abort if a device could not be umounted.
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:57 +00:00
Stefan Schantl
56ce3e19e6 extrahd.cgi: Refactor code to use new introduced perl functions.
This also gets rid of allmost all unsafe system calls.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:57 +00:00
Stefan Schantl
a2c88aadef extrahd.cgi: Add various perl functions deal with block devices
This functions are going to replace the former used scan/write to file/read from
file approach by directly collecting the required informations from the
kernel sysfs and devfs.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-02 09:11:57 +00:00
Jon Murphy
236e89ae87 extrahd.cgi: Fix for Bug #12863
-Fixes remove entries in 'extrahd' via the webinterface for extrahd.cgi file.

Suggested-by: Bernhard Bitsch <bbitsch@ipfire.org>
Signed-off-by: Jon Murphy <jon.murphy@ipfire.org>
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>
2023-06-25 13:48:30 +00:00
Peter Müller
66c3619872 Early spring clean: Remove trailing whitespaces, and correct licence headers
Bumping across one of our scripts with very long trailing whitespaces, I
thought it might be a good idea to clean these up. Doing so, some
missing or inconsistent licence headers were fixed.

There is no need in shipping all these files en bloc, as their
functionality won't change.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
2022-02-18 23:54:57 +00:00
Stefan Schantl
3a69c4fbbc extrahd.cgi: Use new system methods
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
2021-06-10 14:30:54 +01:00
Michael Tremer
0483dca629 extrahd.cgi: Use new system functions
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2021-06-10 14:30:52 +01:00
Matthias Fischer
1d55fccdc5 Syntax fixes in several CGIs
Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2021-01-03 11:13:47 +00:00
Matthias Fischer
d5f061e9e7 Apache 2.4.27 breaks ExtraHD-GUI
Opening 'extrahd.cgi' led to:
"Response header name 'scanhd idescanhd partitionsCache-control' contains
invalid characters, aborting request".

https://forum.ipfire.org/viewtopic.php?f=27&t=19550#p111030
https://forum.ipfire.org/viewtopic.php?f=50&t=19563&sid=575337ac1caf1df492fced01ca6243de#p111048
https://forum.ipfire.org/viewtopic.php?f=22&t=19563#p111052

Signed-off-by: Matthias Fischer <matthias.fischer@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2017-10-02 19:27:52 +01:00
Alf Høgemark
f8aa06792f cgi-bin: Add title attribute to input type image where missing
Almost all of <input type="image"... has both an alt and a
title attribute, but some are missing title, and when the icon
is not very clear, it makes it harder to understand what the icon
does. By adding title, the browser displays text when mouse pointer
is over the icon.

Also add missing quotes for alt and title attributes where needed.
2014-02-19 18:31:02 +01:00
Alexander Marx
dfcb2b9f9a Layout changes extrahd.cgi 2014-01-09 15:02:15 +01:00
Jan Paul Tuecking
1eaa29b151 extrahd.cgi: added again display also non-partitioned disks from Arne. 2011-05-31 23:02:23 +02:00
Jan Paul Tuecking
20730a6fee extrahd.cgi: removed controller names from list, corrected translation. 2011-05-27 14:00:57 +02:00
Arne Fitzenreiter
fac5261ee3 extrahd: fix uuid emtpy string check. 2011-04-21 11:08:14 +02:00
Arne Fitzenreiter
e44dfea3ba extrahd: display also non-partitioned disks. 2011-04-17 18:07:54 +02:00
Arne Fitzenreiter
76d8ffc43b extra hd: fix mountpoint check. 2010-12-20 12:48:52 +01:00
Arne Fitzenreiter
e528205ed8 extrahd: Add UUID to table.
Fix blkid without cache does not work as nobody.
2010-12-10 13:29:23 +01:00
Michael Tremer
784d72a289 extrahd: Use UUID instead of device nodes. 2010-11-29 01:22:57 +01:00
Michael Tremer
bfdd4688c9 Fix bad string in extrahd.cgi "founded drives".
This fixes bug #672.
2010-06-23 11:51:34 +02:00
Arne Fitzenreiter
bb2795c789 Fix cgi permissions. 2009-11-29 14:34:11 +01:00
Jan Paul Tuecking
388ba7bcb0 ExtraHD page is now multilingual. 2009-11-27 07:48:26 +01:00
ms
70df830214 Ein Paar Dateien fuer die GPLv3 angepasst.
git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@853 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-08-29 13:25:32 +00:00
maniacikarus
cb5e9c6c64 Debuginformationen aus den CGIs entfernt
Hoffentlich die letzten Config Types bereinigt
Samba und SSHd init Skripte angepasst
Pakfire CGI optisch angepasst


git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@779 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-08-17 16:00:01 +00:00
maniacikarus
f2fdd0c1e9 Quasi fast alle cgis von den fixen header farben befreit
git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@560 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-05-17 16:54:15 +00:00
ms
aa2870e623 ExtraHD! Die Erweiterung um Festplatten schnell einzubinden!
git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@420 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-02-15 18:17:05 +00:00