webadmin/bpfire
1
0
Fork 0
mirror of https://github.com/vincentmli/bpfire.git synced 2026-04-09 18:45:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

firewall.cgi: Bring back check for single IP when using DNAT.

Browse Source 
This check has been removed by commit: bbe8e009b8

So it was able to create DNAT rules with a network as target.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
This commit is contained in:
Stefan Schantl
2021-07-16 20:20:22 +02:00
committed by Arne Fitzenreiter
parent 446dc99e25
commit 55da553742
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
html/cgi-bin/firewall.cgi
View File

@@ -569,6 +569,24 @@ sub checktarget
#check DNAT settings (has to be single Host and single Port or portrange)
if ($fwdfwsettings{'USE_NAT'} eq 'ON' && $fwdfwsettings{'nat'} eq 'dnat'){
if($fwdfwsettings{'grp2'} eq 'tgt_addr' || $fwdfwsettings{'grp2'} eq 'cust_host_tgt' || $fwdfwsettings{'grp2'} eq 'ovpn_host_tgt'){
# Check if a manual entered IP is a single Host (if set)
if ($fwdfwsettings{'grp2'} eq 'tgt_addr') {
# Split input into address and prefix (if provided).
my ($address, $subnet) = split ('/', $fwdfwsettings{$fwdfwsettings{'grp2'}});
# Check if a subnet is given.
if ($subnet) {
# Check if the prefix or subnetmask is for a single host.
unless ($subnet eq "32" || $subnet eq "255.255.255.255") {
# Set error message.
$errormessage=$Lang::tr{'fwdfw dnat error'}."<br>";
# Return the error.
return $errormessage;
}
}
}
#check if Port is a single Port or portrange
if ($fwdfwsettings{'nat'} eq 'dnat' && $fwdfwsettings{'grp3'} eq 'TGT_PORT'){
if(($fwdfwsettings{'PROT'} ne 'TCP'|| $fwdfwsettings{'PROT'} ne 'UDP') && $fwdfwsettings{'TGT_PORT'} eq ''){