webadmin/bpfire
1
0
Fork 0
mirror of https://github.com/vincentmli/bpfire.git synced 2026-04-09 18:45:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

getrrdimage.cgi: Add default values to parameters

Browse Source 
Prevents "use of uninitialized value" warnings when the
CGI is called with broken undefined GET parameters.

Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de>
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
This commit is contained in:
Leo-Andres Hofmann
2022-04-06 15:46:52 +02:00
committed by Peter Müller
parent df76e77cfb
commit 4c04960ba0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
html/cgi-bin/getrrdimage.cgi
View File

@@ -44,9 +44,9 @@ my @supported_origins = ("entropy.cgi", "hardwaregraphs.cgi", "media.cgi",
my $uri = URI->new($ENV{'REQUEST_URI'});
my %query = $uri->query_form;
my $origin = lc $query{'origin'}; # lower case
my $graph = $query{'graph'};
my $range = lc $query{'range'}; # lower case
my $origin = lc ($query{'origin'} // ''); # lower case
my $graph = $query{'graph'} // '';
my $range = lc ($query{'range'} // ''); # lower case
# Check parameters
unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w\-.,; ]+?$/) && ($range ~~ @Graphs::time_ranges)) {