webadmin/bpfire
1
0
Fork 0
mirror of https://github.com/vincentmli/bpfire.git synced 2026-04-09 18:45:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

remote.cgi: Use new system methods

Browse Source 
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
This commit is contained in:
Stefan Schantl
2021-05-17 23:02:53 +02:00
committed by Michael Tremer
parent 4353c57924
commit 3f5cb3b7cc
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
html/cgi-bin/remote.cgi
View File

@@ -254,7 +254,10 @@ sub viewkey
if ( -e $key )
{
my @temp = split(/ /,`/usr/bin/ssh-keygen -l -f $key`);
# Use safe system_output function to call ssh-keygen and get the output from the tool.
my @ssh_keygen = &General::system_output("/usr/bin/ssh-keygen", "-l", -"-f", "$key");
my @temp = split(/ /, @ssh_keygen);
my $keysize = &Header::cleanhtml($temp[0],"y");
my $fingerprint = &Header::cleanhtml($temp[1],"y");
print "<tr><td><code>$key</code></td><td align='center'>$name</td><td><code>$fingerprint</code></td><td align='center'>$keysize</td></tr>\n";
@@ -264,8 +267,7 @@ sub viewkey
sub printactivelogins()
{
# print active SSH logins (grep outpout of "who -s")
my $command = "who -s";
my @output = `$command`;
my @output = &General::system_output("who", "-s");
chomp(@output);
my $id = 0;