webadmin/bpfire
1
0
Fork 0
mirror of https://github.com/vincentmli/bpfire.git synced 2026-04-25 18:32:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

Network-functions: add check if variables are defined

Browse Source 
in function network_equal and network2bin a check for undefined variables were missing.
added them.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
This commit is contained in:
Alexander Marx
2017-11-07 14:53:27 +01:00
committed by Michael Tremer
parent d6b92a118e
commit 3f3974b711
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
config/cfgroot/network-functions.pl
View File

@@ -111,6 +111,10 @@ sub network_equal {
my @bin1 = &network2bin($network1);
my @bin2 = &network2bin($network2);
if (!defined $bin1 || !defined $bin2) {
return undef;
}
if ($bin1[0] eq $bin2[0] && $bin1[1] eq $bin2[1]) {
return 1;
}
@@ -133,6 +137,10 @@ sub network2bin($) {
my $address_bin = &ip2bin($address);
my $netmask_bin = &ip2bin($netmask);
if (!defined $address_bin || !defined $netmask_bin) {
return undef;
}
my $network_start = $address_bin & $netmask_bin;
return ($network_start, $netmask_bin);