webadmin/bpfire
1
0
Fork 0
mirror of https://github.com/vincentmli/bpfire.git synced 2026-04-23 01:12:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

ids-functions.pl: Use temporary file in downloader.

Browse Source 
Download the requested rules tarball into a temporay file
and if every thing is fine, replace the old by the
downloaded one.

In addition with the previously implemented file size check,
we are saved now from a corrupt rules tarball on disk.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
This commit is contained in:
Stefan Schantl
2018-12-18 15:14:08 +01:00
parent 96da5803a7
commit 25b6545a6e
1 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
config/cfgroot/ids-functions.pl
View File

@@ -196,11 +196,18 @@ sub downloadruleset {
# variable.
my $remote_filesize = $header->content_length;
# Load perl module to deal with temporary files.
use File::Temp;
# Generate temporay file name, located in "/var/tmp" and with a suffix of ".tar.gz".
my $tmp = File::Temp->new( SUFFIX => ".tar.gz", DIR => "/var/tmp/", UNLINK => 0 );
my $tmpfile = $tmp->filename();
# Pass the requested url to the downloader.
my $request = HTTP::Request->new(GET => $url);
# Perform the request and save the output into the "$rulestarball" file.
my $response = $downloader->request($request, $rulestarball);
# Perform the request and save the output into the tmpfile.
my $response = $downloader->request($request, $tmpfile);
# Check if there was any error.
unless ($response->is_success) {
@@ -217,8 +224,8 @@ sub downloadruleset {
# Load perl stat module.
use File::stat;
# Perform stat on the rulestarball.
my $stat = stat($rulestarball);
# Perform stat on the tmpfile.
my $stat = stat($tmpfile);
# Grab the local filesize of the downloaded tarball.
my $local_filesize = $stat->size;
@@ -229,10 +236,19 @@ sub downloadruleset {
&_log_to_syslog("Unable to completely download the ruleset. ");
&_log_to_syslog("Only got $local_filesize Bytes instead of $remote_filesize Bytes. ");
# Delete temporary file.
unlink("$tmpfile");
# Return "1" - false.
return 1;
}
# Load file copy module, which contains the move() function.
use File::Copy;
# Overwrite existing rules tarball with the new downloaded one.
move("$tmpfile", "$rulestarball");
# If we got here, everything worked fine. Return nothing.
return;
}