Commit Graph

69 Commits

Author SHA1 Message Date
Stefan Schantl
c4522a1764 qos.cgi: Fix truncated status output
In the past only the fist line of the status output has been passed
to the cleanhtml() function and displayed. Now the whole output will be
converted to a string, cleaned and displyed on the WUI again.

Fixes #12666.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
2021-09-05 17:42:35 +00:00
Leo-Andres Hofmann
fc81e493b1 qos.cgi: Fix missing translation
Fixes: #12443

Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de>
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
2021-09-05 08:39:33 +00:00
Leo-Andres Hofmann
4190b2a621 rrd graphs: Fix indentation after removing graph output
Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
2021-09-05 08:32:17 +00:00
Leo-Andres Hofmann
05c8c10f19 rrd graphs: Remove unused individual graph output
PNG generation has been moved to getrrdimage.cgi

Signed-off-by: Leo-Andres Hofmann <hofmann@leo-andres.de>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
2021-09-05 08:32:12 +00:00
Michael Tremer
5b8ecec9e8 qos.cgi: Use new perl system functions
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2021-06-10 14:45:27 +01:00
Stefan Schantl
12317449d0 qos.cgi: Use new system methods
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
2021-06-10 14:30:55 +01:00
Jonatan Schlag
8186b37230 Hardcode theme to ipfire
This disables the theme support and makes it impossible to use any other
themes than the ipfire default theme.

The only intention of this patch is to hardcode the theme to ipfire.
To change any cgi we have is an ugly way, but the only way to do this
fast. The colour handling needs certainly to be improved as well, but
this will and should be done in other patches.

Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2021-04-08 10:11:34 +00:00
Michael Tremer
76bf53db8b QoS: Drop support for setting TOS bits per class
This is useless since no ISP will evaluate those settings
any more and it has a rather large impact on throughput.

Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
2019-10-21 18:58:31 +00:00
Michael Tremer
afe23fbb52 QoS: Drop support for subclasses
This feature was never properly implemented and the UI was dead

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Signed-off-by: Daniel Weismüller <daniel.weismueller@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
2019-10-21 18:58:12 +00:00
Arne Fitzenreiter
50e97cd55f Revert "QoS: Drop support for subclasses"
This reverts commit bc4d4da870.
2019-10-20 20:18:00 +00:00
Arne Fitzenreiter
6aeaa3a75e Revert "QoS: Drop support for setting TOS bits per class"
This reverts commit 3174d9c6b6.
2019-10-20 20:17:18 +00:00
Michael Tremer
3174d9c6b6 QoS: Drop support for setting TOS bits per class
This is useless since no ISP will evaluate those settings
any more and it has a rather large impact on throughput.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
2019-10-14 18:04:53 +00:00
Michael Tremer
bc4d4da870 QoS: Drop support for subclasses
This feature was never properly implemented and the UI was dead

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
2019-10-14 18:04:39 +00:00
Daniel Weismüller
20ffa7d1a8 As described in bug 11257 there is a mistake in the qos templates. The sum of the guaranteed bandwidth of the classes 101 - 120 is bigger than the available bandwidth. I adjusted the guaranteed bandwidth of the classes 101 - 104 so that each of them has a
Signed-off-by: Daniel Weismüller <daniel.weismueller@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2018-03-06 15:13:16 +00:00
Michael Tremer
a249ccd2e4 Improve graphs
The graphs are using an iframe and PNG images where the resolution
did often not fit and the browser had to resize the image. That
led to blurred fonts and hard to read graphs.

This patch increases the size of the box and the image. With that
higher resolution resizing should not be too much of an issue, but
since the sizes of the iframe and image have been aligned should
not even be necessary.

Reported-by: Marcel Lorenz <marcel.lorenz@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2017-03-15 13:45:05 +00:00
Michael Tremer
b0a014b7f8 QoS: Improve saving enabled/disable state
It was reported that the QoS did not stop when
the user clicked the "stop" button. This patch
fixes that.

Fixes #10664

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Acked-by: Arne Fitzenreiter <arne.fitzenreiter@ipfire.org>
2016-01-05 21:04:05 +00:00
Lars Schuhmacher
e3edceeb7a Mark required input fields with a star
Mark required input fields with a star as nowadays this is
the de-facto default. Before, it was the other way around and
optional fields were marked.

Signed-off-by: Lars Schumacher <larsen007@web.de>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2015-09-21 16:40:41 +01:00
Michael Tremer
5a7491ffd6 QoS: Actually accept subnets everywhere. 2014-02-27 19:39:18 +01:00
Alexander Marx
5eee5a607e QOS: IP-Addresses can now be simple IP-Address or IP-Address and subnet 2014-02-27 19:12:06 +01:00
Alf Høgemark
be7534e3fa qos.cgi: Show class description in listing, and graph description
When listing the defined qos classes when qos.cgi is initially
displayed, include the description of the class.

Add upload heading for red graph and download graph for imq graph,
since it is not obvious what the graphs means.
2014-02-22 07:07:57 +01:00
Alf Høgemark
f8aa06792f cgi-bin: Add title attribute to input type image where missing
Almost all of <input type="image"... has both an alt and a
title attribute, but some are missing title, and when the icon
is not very clear, it makes it harder to understand what the icon
does. By adding title, the browser displays text when mouse pointer
is over the icon.

Also add missing quotes for alt and title attributes where needed.
2014-02-19 18:31:02 +01:00
Alf Høgemark
597005f5c6 qos.cgi: Use language string keys already defined 2014-02-15 15:23:46 +01:00
Alexander Marx
5ef70cca5d Layout changes qos.cgi 2014-01-09 15:01:34 +01:00
Michael Tremer
40d3e72956 QoS: Don't create template when bandwidth is empty. 2013-02-14 15:35:43 +01:00
Stefan Schantl
48d9bbba75 qos: Remove advanced settings. 2013-02-13 21:35:54 +01:00
Michael Tremer
2b710ab3fa QoS: Use fq_codel instead of sfq. 2012-08-30 19:17:17 +02:00
Arne Fitzenreiter
2106733175 qos-preset: Replaced sip with rtp for voip.
sip is only the signaling protocol and don't need realtime.
2011-05-23 21:50:12 +02:00
Christian Schmidt
4d17a269db Fixed qos device detection on connection type change. 2010-08-29 08:42:37 +02:00
Christian Schmidt
ec3573fc83 Change QoS Port Field to enter Port Ranges. 2010-08-18 11:25:38 +02:00
Jan Paul Tuecking
65e8619acc Removed all german sentences. 2010-03-21 01:30:12 +01:00
Jan Paul Tuecking
11bccc3f30 Added a warning to qos rules that the rule which will be edit has to be saved otherwise it will be discarded. 2009-07-22 20:54:05 +02:00
Arne Fitzenreiter
8de8a50836 qos-preset tuning 2008-10-19 12:15:04 +02:00
Maniacikarus
bcad0fd0d2 3 step in tuning 2.3 2008-09-28 11:10:30 +02:00
Maniacikarus
8b6a7fde91 First part of qos file resize update 2008-09-03 21:20:00 +02:00
Christian Schmidt
1dd22be219 Corrected 2 cgis not fully translated 2008-05-25 13:08:44 +02:00
maniacikarus
773362c5bf Added memory and cpu util graphs for services
Changed collectd config


git-svn-id: http://svn.ipfire.org/svn/ipfire/branches/2.1/trunk@1266 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2008-03-13 19:29:35 +00:00
maniacikarus
99a6f5f9e5 Fixed some things in the qos cgi
git-svn-id: http://svn.ipfire.org/svn/ipfire/branches/2.1/trunk@1265 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2008-03-12 20:48:43 +00:00
maniacikarus
da7e266567 update samba to 3.28 and pakfire release 3
corrected some cgi issues for qos
change qosskript
started core update 2


git-svn-id: http://svn.ipfire.org/svn/ipfire/branches/2.1/trunk@1122 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-12-13 22:10:38 +00:00
ms
fcd5cb6f24 Fixed the branch
git-svn-id: http://svn.ipfire.org/svn/ipfire/branches/2.1/trunk@1076 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-11-11 12:24:46 +00:00
maniacikarus
375c0b3b27 some small code fixes
git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@1049 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-11-03 12:48:03 +00:00
maniacikarus
33e1f48cfb corrected some smaller bugs in some cgiŽs
added support for template in qos


git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@1043 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-11-01 13:12:56 +00:00
ms
70df830214 Ein Paar Dateien fuer die GPLv3 angepasst.
git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@853 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-08-29 13:25:32 +00:00
ms
bb2d1e47fb QoS.cgi speichert jetzt die TOS-Bits nach dem editieren wieder richtig.
git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@803 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-08-22 18:07:20 +00:00
maniacikarus
cb5e9c6c64 Debuginformationen aus den CGIs entfernt
Hoffentlich die letzten Config Types bereinigt
Samba und SSHd init Skripte angepasst
Pakfire CGI optisch angepasst


git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@779 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-08-17 16:00:01 +00:00
maniacikarus
1b73b07ee8 Guardian in Snort eingebaut
QoS CGI wegen den Language Anpassungen korrigiert
Tripwire Policy soll Snortregeln ignorieren
Network Skript angepasst


git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@726 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-07-29 17:55:20 +00:00
maniacikarus
0b1641db6d Qosgraphen in das Standardschema gepackt
Qosgraph CGI komplett neu
Qos CGI multilingual
(ich hoffe das geht ueberhaupt noch was :D )


git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@724 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-07-28 17:03:50 +00:00
ms
51f3b7f5af QoS-Graphen wieder eingebaut.
usbutils und which Paket gemacht.
unbenoetigte Apache-Module werden nicht geladen.
Net-SSLeay gefixt - DynDNS braucht das.
Alsa-Module werden geladen.
Java-paket verkleinert.
Sambactrl gefixt.


git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@652 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-06-30 17:21:34 +00:00
maniacikarus
18322edf27 Ajax Speedmeter ist ueber Guioptions deaktivierbar -> friss gut CPU
Connections CGI sollte die IPSec Verbindungen einfaerben
Hardwaregraphen sollten wieder funktionieren
QOS gefixt,viele kleine Fehler
Squid Initskript setzt die Squid und Squidguard logs auch owner squid


git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@633 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-06-16 14:30:20 +00:00
maniacikarus
268292e730 Viele CGIs geaendert, einige Proxy Dateien hinzugefuegt, iptables aus dem menu geschmissen
git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@612 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-06-06 17:09:21 +00:00
maniacikarus
399d32cbc0 Qos Port und Layer7 Rules sind editierbar
git-svn-id: http://svn.ipfire.org/svn/ipfire/trunk@570 ea5c0bd1-69bd-2848-81d8-4f18e57aeed8
2007-05-21 20:35:30 +00:00