Commit Graph

118 Commits

Author SHA1 Message Date
Michael Tremer
590dcf8703 samba.cgi: Fix styling of the configuration form
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2024-08-21 15:25:13 +02:00
Michael Tremer
0a8800657d samba.cgi: Use the new service status widget
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2024-08-21 15:20:51 +02:00
Adolf Belka
cee7ddb66c samba.cgi: Fixes bug#13193 - disables smb1 unix extensions in smb.conf
- Around three years ago the samba wui page was simplified and several parts were removed
   including the ability to set either wide links or unix extensions to be enabled
- When the above was done wide links = yes was defined in the samba.cgi code
- unix extenstions was not defined and therefore took the default value which was/is yes
- unix extensions is now called smb1 unix extensions and has the same default value of yes
- With both wide links = yes and smb1 unix extensions = yes means that when there is a
  wide symlink (one that goes outside the share directory tree) then wide links is disabled
  because smb1 unix extensions is enabled. This is even though the smb1 protocol is disabled
  by default.
- This patch sets smb1 unix extensions = no in the configuration.
- This has been tested in my vm testbed and confirmed that the error message is no longer
   shown and that any wide links are able to be accessed from the share mounted on a client

Fixes: Bug#13193
Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2023-08-07 09:21:52 +00:00
Peter Müller
66c3619872 Early spring clean: Remove trailing whitespaces, and correct licence headers
Bumping across one of our scripts with very long trailing whitespaces, I
thought it might be a good idea to clean these up. Doing so, some
missing or inconsistent licence headers were fixed.

There is no need in shipping all these files en bloc, as their
functionality won't change.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
2022-02-18 23:54:57 +00:00
Michael Tremer
0fd1f8bba6 samba.cgi: Use new perl system functions
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2021-06-10 14:54:52 +01:00
Jonatan Schlag
8186b37230 Hardcode theme to ipfire
This disables the theme support and makes it impossible to use any other
themes than the ipfire default theme.

The only intention of this patch is to hardcode the theme to ipfire.
To change any cgi we have is an ugly way, but the only way to do this
fast. The colour handling needs certainly to be improved as well, but
this will and should be done in other patches.

Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2021-04-08 10:11:34 +00:00
Michael Tremer
354c3e2b45 samba: Remove option to chose user group and shell
There is no need for this being implemented and it is dangerous to allow
the user to create any shell accounts or users that belong to groups
with higher privileges.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2021-01-27 21:06:57 +00:00
Michael Tremer
1e2c442c9e samba: Add support for custom configuration changes
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-11-09 18:43:15 +00:00
Michael Tremer
a63fe65a2f samba: Make changing shares taking effect immediately
The action was performed after the table has already been
rendered which required reloading the page to show a new
share.

This has now been moved to the top so that new changes
will be shown immediately.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-27 11:37:03 +00:00
Michael Tremer
42772dcb4f samba: Allow rewriting configuration from CLI
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:19 +01:00
Michael Tremer
e768aab5ad samba: Remove unused INTERFACES setting
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:19 +01:00
Michael Tremer
8468cf0489 samba: Use the same delete icon as everywhere else
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:19 +01:00
Michael Tremer
36bcdbf7e4 samba: Refactor user management
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:19 +01:00
Michael Tremer
1bd80edc1d samba: Set a useful default workgroup
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
8649e14977 samba: Remove tbl class from join form
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
f94e17c7c2 samba: Replace security setting with server role
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
8936e2d21b samba: Change share template to something more safe
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
2fa655aec6 samba: Add recycle extension, too
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
bd28bfd9d3 samba: Drop choice to enable/disable wide links/UNIX extensions
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
03e7f9719b samba: Enable support for Apple's OS X by default
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
2d952a57d8 samba: Use full page width for all tables
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
1aa4ecb130 samba: Refactor status area
There is no need to double-wrap the status output in tables.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
98e11f47ac samba: Refactor shares section
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
bdd97e5a50 samba: Remove unused anchors
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
211105897d samba: Remove more legends
These are not helpful and any documentation should be living in the wiki

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
e92b5a0435 samba: Replace save icon with a button and remove legend
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:18 +01:00
Michael Tremer
42ebeaa88e samba: Re-indent global settings table
No functional changes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
e1e399fb10 samba: Replace icons on top of page with buttons
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
d83d30d630 samba: Add tbl class to all <table>s
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
83ae629a72 samba: Drop refresh page hack
This is very invalid HTML, very often inserted into spaces where
it should not be, and the page does not even need to be reloaded
after any action has been performed.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
9e329f75d6 samba: Refactor service status
No functional changes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
8dc8788bee samba: Remove un-exported password sync option
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
c13b64f736 samba: Remove move unused network variables
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
86832d8955 samba: Remove OS level
Samba will chose this automatically and the documentation advises
against changing the default.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
7dea42ae84 samba: Drop PDC default configuration
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
eef84767b0 samba: Remove preferred master option
This is no longer relevant since we cannot run in domain
mode any longer.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
4f00cf381f samba: Remove local master option
It is not a good default to withdraw samba from the race of becoming
the local master browser. There is no reason why it couldn't be.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
70000894e9 samba: Drop support for being PDC for Windows NT domains
This is outdated, and nobody uses it

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
d7129fb107 samba: Drop interfaces configuration
It is virtually impossible to limit samba to these interfaces only.

Therefore we add a static list of all interfaces of the local network.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:17 +01:00
Michael Tremer
01c4d3ba06 samba: Add option to require clients to encrypt the connection
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:16 +01:00
Michael Tremer
be1554336d samba: Export all printers from CUPS
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:16 +01:00
Michael Tremer
97722ab69d samba: Remove printer management
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:16 +01:00
Michael Tremer
1c14930212 samba: Always show printer options
Samba is always linked against CUPS and therefore there is
no way to disable printing anyways.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:16 +01:00
Michael Tremer
a88ea3463c samba: Remove help popup
This is outdated and should be put into the wiki.

It is also some very ugly JS.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:16 +01:00
Michael Tremer
5aa5f6777a samba: Remove reset options
This only requires that we have to change multiple files with
the same settings.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:16 +01:00
Michael Tremer
13e455aec7 samba: Log to syslog
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:16 +01:00
Michael Tremer
1661f0f37f samba: Drop support for WINS
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:16 +01:00
Michael Tremer
762522e0af samba: Remove limitation that server only uses SMB2
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:16 +01:00
Michael Tremer
240b8048ad samba: Drop netbios name option
It makes no sense that the same server has different host names

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:16 +01:00
Michael Tremer
18b7d734a9 samba: Hard-code server string
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
2020-10-13 17:06:16 +01:00