From f09bba1d6c518c647a31ebb8854a16dff748cf2b Mon Sep 17 00:00:00 2001 From: Vincent Li Date: Wed, 9 Jul 2025 22:25:28 +0000 Subject: [PATCH] firewall.cgi: Remove some left-over debugging code commit 0ee4f61deaf50b5c091d94afbedd5615c002cfae Author: Michael Tremer Date: Wed Jun 25 15:22:32 2025 +0100 firewall.cgi: Remove some left-over debugging code This code prevented that any firewall rules could have been created due to the WUI always assuming that there would be some error. Fixes: #13860 - Error message when creating a firewall rule with a subnet for src Signed-off-by: Michael Tremer Signed-off-by: Vincent Li --- html/cgi-bin/firewall.cgi | 5 ----- 1 file changed, 5 deletions(-) diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi index 26d168317..6b1768243 100644 --- a/html/cgi-bin/firewall.cgi +++ b/html/cgi-bin/firewall.cgi @@ -837,11 +837,6 @@ sub checkrule $hint.=$Lang::tr{'fwdfw hint ip2'}." Source: $networkip1/$scidr Target: $networkip2/$tcidr
"; } }else{ - $errormessage .= $sip; - $errormessage .= $scidr; - - $errormessage .= $tip; - $errormessage .= $tcidr; if ( &General::IpInSubnet($networkip2,$sip,&General::iporsubtodec($scidr)) ){ $errormessage.=$Lang::tr{'fwdfw err samesub'} . $fwdfwsettings{'grp1'} .$fwdfwsettings{$fwdfwsettings{'grp1'}} . $fwdfwsettings{'grp2'} . $fwdfwsettings{$fwdfwsettings{'grp2'}};