From 5edf47ffbac2f7a8a668c8b64addd767c3df306b Mon Sep 17 00:00:00 2001
From: Alexander Marx <amarx@ipfire.org>
Date: Wed, 6 Feb 2013 15:14:15 +0100
Subject: [PATCH] Forward Firewall: Bugfix: now the Protocols are corrected in
 the tablerule if a servicegroup was used

---
 html/cgi-bin/forwardfw.cgi | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/html/cgi-bin/forwardfw.cgi b/html/cgi-bin/forwardfw.cgi
index c3acfca28..7e173f505 100755
--- a/html/cgi-bin/forwardfw.cgi
+++ b/html/cgi-bin/forwardfw.cgi
@@ -1703,16 +1703,20 @@ sub get_serviceports
 				$protocols=$customservice{$key}[2];
 			}
 		}
-		
 	}elsif($type eq 'group'){
 		foreach my $key (sort { uc($customservicegrp{$a}[0]) cmp uc($customservicegrp{$b}[0]) } keys %customservicegrp){
 			if ($customservicegrp{$key}[0] eq $name){
-				if($customservicegrp{$key}[4] eq 'TCP'){$tcp='TCP';}else{$udp='UDP';}
+				foreach my $key1 (sort { uc($customservice{$a}[0]) cmp uc($customservice{$b}[0]) } keys %customservice){
+					if ($customservice{$key1}[0] eq $customservicegrp{$key}[2]){
+						if($customservice{$key1}[2] eq 'TCP'){$tcp='TCP';}else{$udp='UDP';}
+					}
+				}
 			}
 		}
 	}
-	if($tcp){$protocols.="TCP";}
-	if($udp){$protocols.=",UDP";}
+	if($tcp && $udp){$protocols="TCP,UDP";
+	}elsif($tcp){$protocols.="TCP";
+	}elsif($udp){$protocols.="UDP";}
 	return $protocols;
 }
 sub viewtablerule