webadmin/bpfire
1
0
Fork 0
mirror of https://github.com/vincentmli/bpfire.git synced 2026-04-09 18:45:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

ddns.cgi: Fixes bug 13884

Browse Source 
commit 0b946b848c72511922fa211b6a4db0da092d204c
Author: Michael Tremer <michael.tremer@ipfire.org>
Date:   Thu Sep 25 16:37:27 2025 +0200

    ddns.cgi: Escape the variables when they are being sent back to the browser

    Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

commit 67db35c8a536b54d169336269853aaa6eae85ab5
Author: Adolf Belka <adolf.belka@ipfire.org>
Date:   Thu Sep 25 13:12:44 2025 +0200

    ddns.cgi: Fixes bug 13884

    Fixes: bug 13884 - ddns.cgi LOGIN PASSWORD SERVICE Stored Cross-Site Scripting
    Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
    Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>
    Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Signed-off-by: Vincent Li <vincent.mc.li@gmail.com>
This commit is contained in:
Vincent Li
2025-10-09 17:33:25 +00:00
parent e44245f5fb
commit 537587ae64
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
html/cgi-bin/ddns.cgi
View File

@@ -523,17 +523,19 @@ print <<END
<td><input type='checkbox' name='ENABLED' $checked{'ENABLED'}{'on'} /></td> <td><input type='checkbox' name='ENABLED' $checked{'ENABLED'}{'on'} /></td>
<td class='username'>$Lang::tr{'username'}</td> <td class='username'>$Lang::tr{'username'}</td>
<td class='username'><input type='text' name='LOGIN' value='$settings{'LOGIN'}' /></td> <td class='username'><input type='text' name='LOGIN'
value='@{[ &Header::escape($settings{'LOGIN'}) ]}' /></td>
<td class='token' style='display:none'>$Lang::tr{'token'}</td> <td class='token' style='display:none'>$Lang::tr{'token'}</td>
<td class='token' style='display:none'><input type='text' name='TOKEN' value='$settings{'TOKEN'}' /></td> <td class='token' style='display:none'><input type='text' name='TOKEN'
value='@{[ &Header::escape($settings{'TOKEN'}) ]}' /></td>
</tr> </tr>
<tr class='password'> <tr class='password'>
<td class='base'></td> <td class='base'></td>
<td></td> <td></td>
<td class='base'>$Lang::tr{'password'}</td> <td class='base'>$Lang::tr{'password'}</td>
<td><input type='password' name='PASSWORD' value='$settings{'PASSWORD'}' /></td> <td><input type='password' name='PASSWORD' value='@{[ &Header::escape($settings{'PASSWORD'}) ]}' /></td>
</tr> </tr>
</table> </table>
<br> <br>